Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33779 )
Change subject: util/cbmem: Update banner string regular expression
......................................................................
Patch Set 1:
(1 comment)
Thanks! One nitpick, then it looks good.
https://review.coreboot.org/#/c/33779/1/util/cbmem/cbmem.c
File util/cbmem/cbmem.c:
https://review.coreboot.org/#/c/33779/1/util/cbmem/cbmem.c@804
PS1, Line 804: OVERFLOW_REGEX("verstage"),
This doesn't belong here, that line can only happen for romstage and ramstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16eba3ac5e203e80b0bfd42a4294401dbccd4463
Gerrit-Change-Number: 33779
Gerrit-PatchSet: 1
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-ping吳宇平
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment