James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31363 )
Change subject: mb/gigabyte: add GA-P67A-UD3R
......................................................................
Patch Set 3:
(1 comment)
Still WIP. Question: do GENx_DEC values with a mask of 0 do anything?
https://review.coreboot.org/c/coreboot/+/31363/2/src/mainboard/gigabyte/ga-p...
File src/mainboard/gigabyte/ga-p67a-ud3r/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/31363/2/src/mainboard/gigabyte/ga-p...
PS2, Line 80: device pci 00.0 on # PCI bridge
: subsystemid 0x1458 0x5000
: end
Can't find a _PRT ACPI method for this in your code. Maybe it's worth to […]
The original firmware has a completely broken _PRT, and in my testing with a RT2561 11g wifi card, the ports work fine without the _PRT method.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fbf50376be3184bf01a3bc8aae09bce54676707
Gerrit-Change-Number: 31363
Gerrit-PatchSet: 3
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 20 Feb 2020 05:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: James
jye836@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
