mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35506 )
Change subject: trogdor: support mbn_version 6 with python build scripts
......................................................................
Patch Set 34:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/createxbl.py
File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/createxbl.py...
PS17, Line 673: if header_version == 5 or header_version == 6:
I'm trying to suggest code that will be easier to maintain going forward. […]
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/createxbl.py...
PS17, Line 687: if header_version == 5 or header_version == 6:
same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I020d1e4d4f5c948948e1b39dd18af1d0e860c279
Gerrit-Change-Number: 35506
Gerrit-PatchSet: 34
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rishabh Sharma
rishabh435@gmail.com
Gerrit-CC: ashk@codeaurora.org
Gerrit-Comment-Date: Wed, 05 Feb 2020 18:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Rishabh Sharma
rishabh435@gmail.com
Gerrit-MessageType: comment