Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate
......................................................................
Patch Set 4:
(2 comments)
Looks like Jenkins complains because of missing includes.
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/nvidia/tegra124/chi...
File src/soc/nvidia/tegra124/chip.h:
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/nvidia/tegra124/chi...
PS4, Line 19:
You need that
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/qualcomm/ipq806x/ua...
File src/soc/qualcomm/ipq806x/uart.c:
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/qualcomm/ipq806x/ua...
PS4, Line 38:
You need that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb
Gerrit-Change-Number: 34233
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment