Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46392 )
Change subject: soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM ......................................................................
Patch Set 8:
(5 comments)
Fix the coding style for now. Will come out a common API for loading MediaTek blob.
https://review.coreboot.org/c/coreboot/+/46392/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46392/4//COMMIT_MSG@2 PS4, Line 2: Odin
Please use *Odin Chen* (maybe).
Ack
https://review.coreboot.org/c/coreboot/+/46392/4//COMMIT_MSG@7 PS4, Line 7: soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM.
Please remove the dot/period at the end of the commit message summary.
Ack
https://review.coreboot.org/c/coreboot/+/46392/4//COMMIT_MSG@8 PS4, Line 8:
Please elaborate, what the firmware is, and how much time it adds to the boot.
The firmware is the MediaTek proprietary for MCU power management.
https://review.coreboot.org/c/coreboot/+/46392/4/src/soc/mediatek/mt8192/mcu... File src/soc/mediatek/mt8192/mcupm.c:
https://review.coreboot.org/c/coreboot/+/46392/4/src/soc/mediatek/mt8192/mcu... PS4, Line 26: void *)(0x0C55FAA0)
define a variable to explain what is 0x0c55faa0
Ack
https://review.coreboot.org/c/coreboot/+/46392/4/src/soc/mediatek/mt8192/mcu... PS4, Line 15: const char *file_name = "mcupm.bin"; : size_t fw_size = cbfs_boot_load_file(file_name, : mcupm_bin, : sizeof(mcupm_bin), : CBFS_TYPE_RAW); : : if (fw_size == 0) { : die("MCUPM file :mcupm.bin not found."); : } : : write32(&mt8192_mcupm->sw_rstn, 0x0); : write32((void *)(0x0C55FAA0), 0x0); : memcpy((void *)MCUPM_SRAM_BASE, mcupm_bin, fw_size); : /* Memory barrier to ensure that all fw code is loaded : before we release the reset pin. */ : mb(); : write32(&mt8192_mcupm->sw_rstn, 0x1);
please indent properly.
Ack