Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80305?usp=email )
Change subject: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80305/comment/0a2ddd9d_0631c7fc : PS1, Line 7: mb
mb/google/nissa/var/yaviks: […]
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/80305/comment/22e02a5b_c516744a : PS1, Line 489: select USE_MTCL
miss DRIVERS_MTK_WIFI? […]
Nothing declares DRIVERS_INTEL_WIFI, but almost all of these boards have variants with Intel WiFi chips. I tried to figure out why that was, and I found the following:
PCIEXP_PLUGIN_SUPPORT is enabled by default (see /src/third_party/coreboot/src/device/Kconfig), so DRIVERS_MTK_WIFI and DRIVERS_INTEL_WIFI are both effectively enabled by default.
This isn't technically necessary (I've tested it multiple times at this point), and it seems to go against convention. My inclination (unless there's a strong preference otherwise) is to not add this.