[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Initialise overridetree

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Eric Lai, Lawrence Chang, Weimin Wu.

Karthik Ramasubramanian has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83496?usp=email )

Change subject: mb/google/dedede/var/awasuki: Initialise overridetree
......................................................................

Patch Set 6:

(2 comments)

File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/83496/comment/65e4fc2b_d45ec0b0?usp... :
PS6, Line 21: 	#| I2C1              | Disable                   |
            : 	#| I2C2              | Touchscreen               |
            : 	#| I2C3              | Disable      
Also you need to do disable I2C in FSP config like below:

```
    register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,
    	[PchSerialIoIndexI2C1]  = PchSerialIoDisabled,
    	[PchSerialIoIndexI2C2]  = PchSerialIoPci,
    	[PchSerialIoIndexI2C3]  = PchSerialIoDisabled,
    	[PchSerialIoIndexI2C4]  = PchSerialIoPci,
    	[PchSerialIoIndexI2C5]  = PchSerialIoDisabled,
    }"
```

https://review.coreboot.org/c/coreboot/+/83496/comment/08e25591_3278a218?usp... :
PS6, Line 204: device pci 1c.7 on
             : 			chip drivers/wifi/generic
             : 				register "wake" = "GPE0_DW2_03"
             : 				device pci 00.0 on end
             : 			end
Does this board also support external/discrete Wifi? You need this only when discrete Wifi is used.