Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44238 )
Change subject: cpu/intel/model_68x_6bx: Update ucode before enabling cache
......................................................................
Patch Set 4:
(1 comment)
Keith, could you please boot-test this change?
https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx...
File src/cpu/intel/model_68x_6bx/model_68x_6bx_init.c:
https://review.coreboot.org/c/coreboot/+/44238/4/src/cpu/intel/model_68x_6bx...
PS4, Line 18:
: /* Turn on caching if we haven't already */
: x86_enable_cache();
is this tested ?
That's why I added Keith as a reviewer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44238
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dda712043e1d17c3cc860d38b5daf8adfa882fa
Gerrit-Change-Number: 44238
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 10:00:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment