Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42074 )
Change subject: soc/amd/common: Refactor SMBus base arguments
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s...
File src/soc/amd/common/block/smbus/smbus.c:
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s...
PS10, Line 15: union reg_bank {
: uint8_t reg8[0x100];
: uint16_t reg16[0x100 / sizeof(uint16_t)];
: };
With the base address passed on the stack now, this does not seem to happen. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e0ebd7609c5c83d0e443ffba74dae68017d3ebc
Gerrit-Change-Number: 42074
Gerrit-PatchSet: 13
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jul 2020 03:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment