Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1075 PS12, Line 1075: endif Why move this? It's used right below in line 1088 and not specific to FIT.
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@a1185 PS12, Line 1185: $(IFITTOOL) -f $@.tmp -D $(TS_OPTIONS) -r COREBOOT The new comment suggests that this should have stayed?
https://review.coreboot.org/c/coreboot/+/46453/12/Makefile.inc@1153 PS12, Line 1153: TS_OPTIONS := -j $(CONFIG_INTEL_TOP_SWAP_BOOTBLOCK_SIZE) This is redundant with the same line in the new file.
Does it even work inside a recipe?
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/12/src/cpu/intel/fit/Makefile... PS12, Line 10: ifneq ($(CONFIG_CPU_MICROCODE_CBFS_NONE),y) Maybe add an empty line below this and above the matching `endif`, to make it more visible that it encloses the rest of the file.