Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39360 )
Change subject: mb/google/dedede: Add camera support for WDoo
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@7
PS16, Line 7: WDoo
Please mention the full name Waddledoo somewhere.
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@9
PS16, Line 9: schmatics
schematics
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@13
PS16, Line 13:
I’d prefer if the baseboard and variant change were in separate commits. Something like:
- mb/google/dedede: Add camera support for variants
- mb/google/dedede/variants/waddledoo: Select camera support
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8687bce4896d9fc17b2190b8d11618af3515cc1
Gerrit-Change-Number: 39360
Gerrit-PatchSet: 16
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 16 Apr 2020 09:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment