Attention is currently required from: Kangheui Won, Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61141 )
Change subject: [WIP] mb/google/nissa: Add devicetree ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61141/comment/53116640_e0e69601 PS1, Line 4: register "pmc_gpe0_dw0" = "GPP_A" : register "pmc_gpe0_dw1" = "GPP_H" : register "pmc_gpe0_dw2" = "GPP_F" Should these be sorted, or is it intentional to minimise the delta from brya?
https://review.coreboot.org/c/coreboot/+/61141/comment/e61c25ea_37c9b04e PS1, Line 24: USB2_C1 Do we need to handle the fact that C1 and A1 may be used differently, or not at all, depending on the USB sub-board? E.g. this one isn't used on the HDMI sub-board.
https://review.coreboot.org/c/coreboot/+/61141/comment/0d1f2677_19eaa945 PS1, Line 58: register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T" : register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ" Where do these come from?
https://review.coreboot.org/c/coreboot/+/61141/comment/b3b2338e_b3012a45 PS1, Line 72: Sub-board Specifically it's used for the SAR sensor. Also, it looks like nivviks uses it for the MIPI WFC too.
https://review.coreboot.org/c/coreboot/+/61141/comment/d0f13867_d610b633 PS1, Line 125: end : device eMMC?