Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34459/5/payloads/external/tianocore...
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/5/payloads/external/tianocore...
PS5, Line 90: config TIANOCORE_BOOTLOADER
: bool "TianoCore UEFI Payload"
: help
: UEFIPayload supports coreboot and slimboot.
:
I still don't see why we should add an unmaintained bootloader-selection that only works with upstream. Upstream was broken quite often, that's why we switched to a stable branch.
I think the argument could be made that if it's not easy to test UefiPayloadPkg via coreboot's build system, then the likelihood of it being properly maintained drops significantly.
If we have two payload options then it makes it easier to test, and we can switch the default to UefiPayloadPkg once it reaches the point to where it's a better option
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7785fde9f4113b2cd91323ac0358b229c5a6e6
Gerrit-Change-Number: 34459
Gerrit-PatchSet: 5
Gerrit-Owner: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 15:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment