Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46352 )
Change subject: soc/intel/broadwell: Drop reg-script usage from bootblock PCH init ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46352/2/src/soc/intel/broadwell/boo... File src/soc/intel/broadwell/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/46352/2/src/soc/intel/broadwell/boo... PS2, Line 82: RCBA32_AND_OR(HPTC, ~3, 1 << 7);
Nak
Elyes, what you seem to predict there doesn't make any sense. Also, any overflow would be intentional. You probably refer to the spurious compiler warnings that we don't enable? Please do not block coreboot development because of potential future issue that can be avoided in one way or another.
The macro still exists and it's safe to be used like that. You should know that or not add blocking comments. You can always mark comments as resolved if you are not 100% sure that things should be blocked.