Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )
Change subject: sc7280: Provide initial SoC support ......................................................................
Patch Set 24:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45205/comment/63955619_d41e6f3b PS2, Line 7: sc7280
Is there a rule about that? Considering that patch subject space is often too short to really convey […]
Done
https://review.coreboot.org/c/coreboot/+/45205/comment/fc7cc450_2a0a45e4 PS2, Line 7: sc7280
Is there a rule about that? Considering that patch subject space is often too short to really convey […]
Done
File src/soc/qualcomm/sc7280/include/soc/symbols.h:
https://review.coreboot.org/c/coreboot/+/45205/comment/606c8741_85be1015 PS6, Line 15: DECLARE_REGION(aop)
Should probably just dump these into <soc/symbols_common.h> rather than duplicate between chips. […]
Done
File src/soc/qualcomm/sc7280/qclib.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/da37c8af_3db27737 PS6, Line 9: int qclib_soc_blob_load(void)
Please factor this out in qualcomm/common if it's needed by more than one SoC. […]
Sure julius, We will make this change once discuss with internal team
File src/soc/qualcomm/sc7280/timer.c:
https://review.coreboot.org/c/coreboot/+/45205/comment/390c9348_02c710f1 PS6, Line 7: void init_timer(void)
Should consider putting this in qualcomm/common and just using SRC_XO_HZ from <soc/clock. […]
Sure julius, we will make this change once discuss with internal team