Attention is currently required from: Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 27:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/9030f866_51a3838f PS27, Line 11: bool aop_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/e4a89bb5_bca33fa3 PS27, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/54d6d3d7_0756b210 PS27, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/31117663_af5c402d PS27, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/9a88ab86_0937c5eb PS27, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/178d0b93_a848cb3d PS27, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/c1036f03_5548da58 PS27, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/a564d2eb_719fadf5 PS27, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/d0b722cf_eff7a812 PS27, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/33b0a070_9349f670 PS27, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/2c492f7c_e6828a12 PS27, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/5146c929_d0fd4798 PS27, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/da268a2e_dae9093e PS27, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/e344e4ec_0afcf2c1 PS27, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/62aef1ed_4f191f68 PS27, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/f0c308a0_316221c5 PS27, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/18636704_7f159fe8 PS27, Line 23: clock_reset_aop(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/20cc7a4c_618497c7 PS27, Line 23: clock_reset_aop(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/6d67cc1c_a2a4742e PS27, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/a4361292_3a77a6c1 PS27, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/f59d0f39_3ee308cf PS27, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/6ecf45f8_0ab5f580 PS27, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/18c07e69_501d88fd PS27, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/7c4828ef_2de6e879 PS27, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/ef39b5b9_8b2701e6 PS27, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/92caf238_59ad95cc PS27, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line