Attention is currently required from: Paul Menzel. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48424 )
Change subject: asus/a88xm-e: properly program the IRQ tables ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48424/comment/7d3c978c_f3409956 PS1, Line 13:
How did you determine the values? Just copying them from the Asus AM1I-A?
No, there is a certain unwritten algorithm which helped to get the board-specific values for A88XM-E (and G505S). I have trouble remembering it, but it could be understood by looking at am1i-a and other boards as the examples - and in any case I'm not sure I did it 100% correctly, since all this stuff is really tricky, but I tried my best.
https://review.coreboot.org/c/coreboot/+/48424/comment/353e85c2_fe701195 PS1, Line 15: * A88XM-E boots fine to Linux - no angry IRQ-related messages at dmesg;
Can you please paste one of these messages in the git commit message?
One of the possible messages is "irq 17: nobody cared (try booting with the "irqpoll" option)". There were also the more prominent ones, which caused the kernel oopses/panicks but I have trouble locating them at the moment. The thing is, if you've done the IRQ routing really wrong, it's likely the kernel will let you know (or you'd just notice that some device isn't working).
Patchset:
PS1:
Please see the two change-sets below for a solution for all AGESA boards. […]
I've already tried going this route but lacked something - time, patience or skill (you decide) - to figure out the IRQ tables autogeneration. So I did it what I could: fixed the IRQs for the three boards which I own, statically and with a lot of trial and error. If someone else also wants to fix the IRQs of his board the same way, he could use my am1i-a/a88xm-e/g505s IRQ patches as the examples. https://review.coreboot.org/c/coreboot/+/48427 - "AMD good IRQs"
File src/mainboard/asus/a88xm-e/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48424/comment/74ed88f8_a184c2dd PS1, Line 17: * This table defines the index into the picr/intr_data
Please rewrap the comment to use 72 characters per line.
This should be done in the follow-up change - and not just for ASUS A88XM-E but for the many boards across the tree. Any optional changes like this comment change, if done alone - would make it harder to compare in kdiff3/meld vs the other boards, so shouldn't be done unless truly necessary.