EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40114 )
Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG@7
PS2, Line 7: touchpad
for Deltan
Done
https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau...
PS2, Line 3: register "pmc_gpe0_dw1" = "GPP_E"
I would prefer the GPE settings go into the baseboard devicetree, they should hopefully be identical […]
will do
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028
Gerrit-Change-Number: 40114
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Apr 2020 02:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment