Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76999?usp=email )
Change subject: mb/hp/revolve_810_g1: Drop old SPD info and unused includes ......................................................................
mb/hp/revolve_810_g1: Drop old SPD info and unused includes
mainboard_get_spd() replaced by mb_get_spd_map().
Change-Id: I82bdc510658e0d4625f3d1cd0e5502755808b420 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/early_init.c 1 file changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/76999/1
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/early_init.c b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/early_init.c index 3c4447b..2799a85 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/early_init.c +++ b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/early_init.c @@ -1,11 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <string.h> -#include <cbfs.h> -#include <console/console.h> #include <northbridge/intel/sandybridge/raminit.h> -#include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <ec/hp/kbc1126/ec.h>
@@ -36,19 +32,6 @@ kbc1126_exit_conf(); }
-void mainboard_get_spd(spd_raw_data *spd, bool id_only) -{ - /* C1S0 is a soldered RAM with no real SPD. Use stored SPD. */ - size_t spd_file_len = 0; - void *spd_file = cbfs_map("spd.bin", &spd_file_len); - - if (!spd_file || spd_file_len < sizeof(spd_raw_data)) - die("SPD data for C1S0 not found."); - - read_spd(&spd[0], 0x50, id_only); - memcpy(&spd[2], spd_file, spd_file_len); -} - void mb_get_spd_map(struct spd_info *spdi) { spdi->addresses[0] = 0x50;