Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub "Kuba" Czapiga, Kapil Porwal, Tarun, Tony Huang.
Paul Menzel has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/86603?usp=email )
Change subject: mb/google/ovis/var/deku: Update retimer tcss port number
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86603/comment/1df2da44_8c2e1587?usp... :
PS2, Line 7: number
number*s*?
https://review.coreboot.org/c/coreboot/+/86603/comment/8ff91bd6_deaa2ec4?usp... :
PS2, Line 9: use
uses
https://review.coreboot.org/c/coreboot/+/86603/comment/f7cb27e5_c10414cd?usp... :
PS2, Line 23:
Thank you for adding the commands to test this. It’d still be great if you mentioned also the schematic version you used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86603?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I763d11c5caae28c49514745d47fda0d6ca200faf
Gerrit-Change-Number: 86603
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 11:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes