Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35769 )
Change subject: sb/intel/ibexpeak: Don't clear PMBASE regs in romstage
......................................................................
Patch Set 6:
Patch Set 6:
Is there common code clearing those bits? Why don't you need to clear it?
No other Intel platform does that in romstage and this is likely here as a copy from disassembled vendor firmware or a SerialICE trace. Handling those is done by the code that sets up SMM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35769
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a8e598b07bf0a059dcb47651d1a26456863673
Gerrit-Change-Number: 35769
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Oct 2019 09:53:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment