Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 32:
(2 comments)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/ddab74b4_aaeb0b91 PS27, Line 431: enum type_c_orientation {
I like the idea of adding the enum in a follow-up. […]
I split it out into 58084 (see new dependency chain).
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/987878f7_bfd8cbb5 PS8, Line 99: struct drivers_intel_pmc_mux_conn_config *config = child->chip_info; : if (config) { : info[count].usb2_port_number = config->usb2_port_number; : info[count].usb3_port_number = config->usb3_port_number; : info[count].sbu_orientation = config->sbu_orientation; : info[count].data_orientation = config->hsl_orientation; : count++; : }
Is the new conn_get_type_c_list() sufficient for that purpose? If not, are there additional checks […]
Done