Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33294 )
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c File src/northbridge/intel/gm45/raminit.c:
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c... PS1, Line 1597: Mirrored ranks aren't taken into account here. Don't you just need to switch some bits for that? void send_jedec_cmd() in northbridge/intel/x4x/raminit_ddr23.c does that.