build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38772 )
Change subject: mb/google/dedede: Enable AP <-> H1 Communication ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38772/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38772/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38772/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38772/1/src/mainboard/google/dedede... PS1, Line 39: PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38772/1/src/mainboard/google/dedede... PS1, Line 39: PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), please, no spaces at the start of a line