8 Mar
2020
8 Mar
'20
12:10 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39384 )
Change subject: mb/asus/p5g41t-m_lx: Do not set BSEL GPIOs in devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39384/1/src/mainboard/asus/p5qpl-am... File src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39384/1/src/mainboard/asus/p5qpl-am... PS1, Line 53: irq 0xf4 = 0xa4 This differs from the early-init value? It doesn't seem wrong wrt. GPIOs 43 & 44. Are we sure the early value doesn't enable too many outputs?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ea498119df44243ec42e3cb5c2903de32a17373
Gerrit-Change-Number: 39384
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 08 Mar 2020 19:10:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment