Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: Add support for OCP platform TiogaPass
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@9
PS4, Line 9: 2 socket
this works as an adjective, so it should be hyphenated: 2-socket
https://review.coreboot.org/c/coreboot/+/38549/4//COMMIT_MSG@9
PS4, Line 9: platform based on
: Intel Skylake-SP SOC. The chipset includes Lewisburg PCH.
I would rewrite this part a bit:
platform, which combines Skylake-SP processors with the Lewisburg PCH.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29868f03037d1887b90dfb19d15aee83c456edce
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Thu, 23 Jan 2020 23:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment