[coreboot-gerrit] Change in coreboot[master]: soc/qualcomm/ipq806x: Remove unnecessary allocation

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34499 )

Change subject: soc/qualcomm/ipq806x: Remove unnecessary allocation
......................................................................

soc/qualcomm/ipq806x: Remove unnecessary allocation

The bus variable doesn't live outside the scope of this function, and is
only used as a convenient way for passing the pointers to all the
sub-functions, so it doesn't need to be allocated. Put it on the stack
instead.

Change-Id: I4370d77445952731d20f7d9a91803612f4d21aef
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1294801
---
M src/soc/qualcomm/ipq806x/lcc.c
1 file changed, 5 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/34499/1

diff --git a/src/soc/qualcomm/ipq806x/lcc.c b/src/soc/qualcomm/ipq806x/lcc.c
index 68b878c..5a9274f 100644
--- a/src/soc/qualcomm/ipq806x/lcc.c
+++ b/src/soc/qualcomm/ipq806x/lcc.c
@@ -287,13 +287,7 @@

int audio_clock_config(unsigned frequency)
 {
-	Ipq806xLccClocks *bus = malloc(sizeof(*bus));
-
-	if (!bus) {
-		printk(BIOS_ERR, "%s: failed to allocate bus structure\n",
-		       __func__);
-		return 1;
-	}
+	Ipq806xLccClocks bus;

bus->gcc_apcs_regs = (void *)(MSM_GCC_BASE + GCC_PLL_APCS_REG);
    bus->lcc_pll0_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL0_MODE_REG);
@@ -301,15 +295,13 @@
    bus->lcc_mi2s_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_MI2S_NS_REG);
    bus->lcc_pll_regs = (void *)(MSM_LPASS_LCC_BASE + LCC_PLL_PCLK_REG);

-
-	if (lcc_init_enable_pll0(bus))
+	if (lcc_init_enable_pll0(&bus))
    	return 1;
-	if (lcc_init_enable_ahbix(bus))
+	if (lcc_init_enable_ahbix(&bus))
    	return 1;
-	if (lcc_init_mi2s(bus, frequency))
+	if (lcc_init_mi2s(&bus, frequency))
    	return 1;
-
-	if (lcc_enable_mi2s(bus))
+	if (lcc_enable_mi2s(&bus))
    	return 1;

return 0;