Attention is currently required from: Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
Change subject: gma pipe_setup: Update for TGL & ADL ......................................................................
Patch Set 33: Code-Review+1
(4 comments)
File common/hw-gfx-gma-pipe_setup.adb:
https://review.coreboot.org/c/libgfxinit/+/67494/comment/008a194a_5faeead9 : PS32, Line 46: PLANE_COLOR_CTL_GAMMA_DISABLE : constant := 1 * 2 ** 13;
I didn't want to drop the CTL_ (part of the register name), but added the PLANE_.
Works for me
https://review.coreboot.org/c/libgfxinit/+/67494/comment/9f7e3fd9_7c7f7455 : PS32, Line 254: then PLANE_CTL_ARB_SLOTS (1)
On TGL we use the hardware defaults, i.e. don't set USE_PROGRAMMED_SLOTS. […]
IIRC the PRMs say that 0 is the default, but it's late and I don't trust myself.
https://review.coreboot.org/c/libgfxinit/+/67494/comment/30d4dd7c_b5002f80 : PS32, Line 380: -- ADL_P requires that we disable underrun recovery when : -- downscaling (or using the scaler for YUV420 pipe output), : -- using DSC, or using PSR2.
Anything to do beside updating the comment?
Besides updating the comment, we should unconditionally disable underrun recovery for `DISPLAY_VER(i915) >= 13`. So `Need_Underrun_Rec_Disable` needs to be `Alderlake_On` if it isn't already.
https://review.coreboot.org/c/libgfxinit/+/67494/comment/d2a36471_dc2c7b77 : PS32, Line 441: Has_TGL_Plane_Control
I also stumbled over this. And I actually see no reason to set these bits. […]
IIRC i915 sets them depending on the display (engine) version, so I wouldn't use a named config for this.