Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38221 )
Change subject: soc/amd/picasso: Drop forked copy of SMBus source ......................................................................
Patch Set 4:
Angel, thanks for your opinion. My reasoning is that the patch strips functionality from an soc where I'm actively trying to complete development, and it does not replace it with an alternative.
If you give a patch a -2, you are responsible for giving concrete recommendations for what could be changed to resolve the issue the patch addresses.
As I stated early, the right approach is to move the feature out of stoneyridge and into common so it's sharable between the stoneyridge and picasso. I'm even happy to do this work, however it's substantially lower in priority than my other areas of focus. If I do the work, then it must come at the cost of a delay. I'm fine, however, with my keeping the fork in sync with stoneyridge (i.e. the change in CB:38222) until the time comes that I can commonize the code.
But let's be clear, my -2 here is not holding up merging CB:38222. Those complaints don't hold up.
So again, thank you for sharing your opinion, but I'm not yet ready to agree to having a project defeatured like this while I'm trying to finish it. I'd like to hear others weigh in on why this should be removed, and tell me where I'm wrong.