Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: arch/x86: Add symbols for CAR MTRRs in linker script ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld@3 PS7, Line 3: #include <cpu/x86/mtrr.h>
What did we need this #include for again? LOG2CEIL is a linker thing.
Could you comment on this?
https://review.coreboot.org/c/coreboot/+/30872/9/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/9/src/arch/x86/car.ld@83 PS9, Line 83: _car_mtrr_start = _car_region_start; And we'd expose this value for which stages? Presumably these would only need to be exposed in C_ENVIRONMENT_BOOTBLOCK && ENV_BOOTBLOCK || (!C_ENVIRONMENT_BOOTBLOCK && ENV_ROMSTAGE) ?