build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27416 )
Change subject: mediatek: Share GPIO code among similar SOCs
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/27416/5/src/soc/mediatek/mt8173/include/soc/...
File src/soc/mediatek/mt8173/include/soc/gpio.h:
https://review.coreboot.org/#/c/27416/5/src/soc/mediatek/mt8173/include/soc/...
PS5, Line 38: #define PIN(id, name, func1, func2, func3, func4, func5, func6, func7) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/27416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0
Gerrit-Change-Number: 27416
Gerrit-PatchSet: 5
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Jul 2018 13:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No