Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45235 )
Change subject: libpayload: cbgfx: Fix 'equals' counter for Lanczos resampling ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
(1 comment)
Can you explain exactly what the problem is (or did you just try around until it went away)?
Explained in more details in the commit message. Please check PS2.
https://review.coreboot.org/c/coreboot/+/45235/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45235/1//COMMIT_MSG@9 PS1, Line 9: The 'equals' counter stores the number of latest pixels that were
Please summarize the problem first.
Done
https://review.coreboot.org/c/coreboot/+/45235/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/45235/1/payloads/libpayload/drivers... PS1, Line 873: sx
I think this needs to be (sx - S0 >= dim_org->width), btw.
Yes, you're right. Corrected.
I guess if the font glyph bitmaps are very small, this could actually be the reason for your bug?
Actually no. dim_org->width is 9 for puff and SSZ is 6, so this condition will never be reached.