Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37378 )
Change subject: vendorcode/cavium/bdk/libdram: Add missing <stdlib.h>
......................................................................
Patch Set 6:
Wait for someone else to comment on this. My suggestion would be to use MAX() here and also remove existing defines of min() and max() in <stdlib.h>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ded44422a267e244343502dd5d6ab355e5a788d
Gerrit-Change-Number: 37378
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 19:33:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment