Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Kconfig: Create coreboot separate stage kconfigs
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+1
The other bit to get correct here is removing the root dependencies if these values are not selected. I think if you do that correctly then many of the follow up CLs aren't needed since Make won't try evaluating the rules.
Do you like to club all ENABLE_STAGE_<> related changes into this CL? In that way i believe we will loose traceability
Not necessarily, but as things currently stand this CL doesn't really do anything. We should be plumbing the removal of the root dependencies based on these Kconfigs in this CL, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f7e4174619016c5a54c28bedd52699df417a5b7
Gerrit-Change-Number: 33142
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 16:23:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment