18 Feb
2019
18 Feb
'19
1:13 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31448/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/#/c/31448/1/src/device/pci_device.c@803 PS1, Line 803: if (pci_class == PCI_CLASS_DISPLAY_VGA) I don't quite understand how you could use the class to distinguish between integrated and discrete graphics. Don't standard PCIe graphics cards usually advertise PCI_CLASS_DISPLAY_VGA?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31448
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3269a0911e86ea07014484365c7c830485e52ec
Gerrit-Change-Number: 31448
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Feb 2019 21:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment