Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#28).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc. There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family. It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments).
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/28