Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 130: int swinf_no; Can the number be signed?
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 131: int mstid; Should an id be unsigned?
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/pmif_spi.h:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 55: PMIC_BASE = 0x0000, : PMIC_SMT_CON1 = PMIC_BASE + 0x0032, : PMIC_DRV_CON1 = PMIC_BASE + 0x003a, : PMIC_FILTER_CON0 = PMIC_BASE + 0x0042, : PMIC_GPIO_PULLEN0_CLR = PMIC_BASE + 0x0098, : PMIC_RG_SPI_CON0 = PMIC_BASE + 0x0408, : PMIC_DEW_DIO_EN = PMIC_BASE + 0x040c, : PMIC_DEW_READ_TEST = PMIC_BASE + 0x040e, : PMIC_DEW_WRITE_TEST = PMIC_BASE + 0x0410, : PMIC_DEW_CRC_EN = PMIC_BASE + 0x0414, : PMIC_DEW_CRC_VAL = PMIC_BASE + 0x0416, : PMIC_DEW_RDDMY_NO = PMIC_BASE + 0x0424, : PMIC_RG_SPI_CON2 = PMIC_BASE + 0x0426, : PMIC_SPISLV_KEY = PMIC_BASE + 0x044a, : PMIC_INT_STA = PMIC_BASE + 0x0452, : PMIC_AUXADC_ADC7 = PMIC_BASE + 0x1096, : PMIC_AUXADC_ADC10 = PMIC_BASE + 0x109c, : PMIC_AUXADC_RQST0 = PMIC_BASE + 0x1108, Please use either tabs or spaces for alignment.
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/spmi.h:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 46: int slvid; Can an ID be signed?