EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37793 )
Change subject: soc/intel/common: Add GPIO PM override configuration into NVS
......................................................................
Patch Set 3:
Patch Set 3:
@Furquan, if you don't like NVS. I propose use Kconfig as well.. And can solve the APL issue in the same time. Add CONFIG_SUPPORT_GPIO_PM in soc level and we can override it in board level. One stone for two birds.
My concern is that by adding NVS or Kconfig, we are not really gaining much since it would be anyways used by all current boards. In the future, if we really need this for some mainboard, we can always add that config/NVS variable. Please see my comment here: https://review.coreboot.org/c/coreboot/+/37685/11/src/soc/intel/common/acpi/...
Okay, we can discuss there :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4f950d97c7d1dbe22f6e57cd502afde6935d831
Gerrit-Change-Number: 37793
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Dec 2019 12:35:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment