22 Jul
2020
22 Jul
'20
3:41 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43718 )
Change subject: ec/system76: Add console support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG@9 PS2, Line 9: This adds support for line-buffered console output to System76 EC firmware.
Once the print command is received, the EC firmware multiplexes the output to any enabled console on […]
I see. It would be good to mention this in the commit message. I was wondering why the generic 8250io driver couldn't be used for this EC.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I861bf3e22f40dd6c3ec7ba1d73711b399358e332
Gerrit-Change-Number: 43718
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 22 Jul 2020 13:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeremy Soller jeremy@system76.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment