Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )
Change subject: soc/intel/cannonlake: Add support for UART2 on PCH-H ......................................................................
Patch Set 4: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... File src/soc/intel/cannonlake/pch_h.c:
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... PS4, Line 3: #include <arch/acpi.h> fix includes
https://review.coreboot.org/c/coreboot/+/40405/4/src/soc/intel/cannonlake/pc... PS4, Line 4: arch acpi/acpigen.h