Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40038 )
Change subject: soc/intel/jasperlake: Remove DDI A lane programming ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@9 PS1, Line 9: For newer Intel graphics(>=11), The DDI port max lanes are set to 4 by
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@9 PS1, Line 9: The
the
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@10 PS1, Line 10: default. And kernel driver no longer relies on coreboot to provide
… lanes default to 4.
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@11 PS1, Line 11: information via DDI_BUF_CTL_A(for DDI port A) register programming.
Space before (.
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@14 PS1, Line 14: BRANCH=None
BUG=?
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@16 PS1, Line 16: Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com
next line? […]
Done
https://review.coreboot.org/c/coreboot/+/40038/1//COMMIT_MSG@18 PS1, Line 18: Change-Id: I4c171ec6a57d6fc53bee88420bfb3c0fbc5dc057
Please move this directly above the Signed-off-by line.
Done