Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32322 )
Change subject: soc/intel/cannonlake: Add null refrence check for Cnvi and Xdci ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32322/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32322/3//COMMIT_MSG@8 PS3, Line 8:
Was this reported by coverity?
I did not check on that. Just caught my eye.
https://review.coreboot.org/#/c/32322/3/src/soc/intel/cannonlake/fsp_params.... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32322/3/src/soc/intel/cannonlake/fsp_params.... PS3, Line 258: IS_ENABLED(CONFIG_SOC_INTEL_COMETLAKE)
IS_ENABLED has been deprecated. Please use CONFIG(SOC_INTEL_COMETLAKE) instead like it was before.
Sorry that was a miss, corrected it now.