Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32326 )
Change subject: kohaku: mb/hatch/gpio: Scrub Kohaku GPIOs. ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
PS3: This file needs to be added to Makefile.inc for kohaku
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 21: gpio_table From the implementation, it looks like you are intending to treat this as an override table? If yes, then this code needs to be updated to take care of that: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
See https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/octo... as an example.
With the current implementation, kohaku will end up configuring only the GPIOs in this table.
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 87: ACPI_S5 There is no need to distinguish sleep type if there is only one sleep gpio table.
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 92: default_sleep_gpio_table Where is this defined?