[coreboot-gerrit] [M] Change in coreboot[main]: drivers/wwan/fm: Wake up modem on PEWAKE# signal change

[Paweł Anikiel (Code Review)]

Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Subrata Banik.

Paweł Anikiel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email )

Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
......................................................................

Patch Set 3:

(2 comments)

File src/drivers/wwan/fm/acpi_fm350gl.c:

https://review.coreboot.org/c/coreboot/+/78297/comment/3bfe923e_817341f0 :
PS3, Line 6: #if CONFIG(GENERIC_GPIO_LIB)
           : #include <gpio.h>
           : #endif
> order please. […]

Same as below, it's copied over from `acpi/device.c`.

https://review.coreboot.org/c/coreboot/+/78297/comment/6b44fd77_29d78d85 :
PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB)
> why preprocessing guard ?

I needed to get the pin number and the GPIO controller's scope name from a `struct acpi_gpio`. I looked at the implementation of `acpi_device_write_gpio()`, because it writes out both of these things. This implementation uses lots of GENERIC_GPIO_LIB ifdefs, so I copied over exactly what it did.

Is there a better way of doing this? If so, I'll use it.