Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36770 )
Change subject: mb/asrock: add Asrock B85M Pro4
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 3:
Patch Set 3:
Should be good to go.
Maybe add a little summary of what was tested?
Would a variant of H81M-HDS be a good idea?
I am having problems with Linux oopsing when loading hwmon-related drivers.
I didn't make it a variant as I would like to make changes to this board's code without breaking H81M-HDS by accident.
Forgot to mention: the integrated Intel network device does not appear on PCI at all, so this needs to be addressed. Also documentation is missing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a16dfc56f2aa88648c8aaaba4feab40c491504
Gerrit-Change-Number: 36770
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 Nov 2019 09:09:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment