Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44064 )
Change subject: mb/google/zork: use defines for all DXIO port numbers
......................................................................
Patch Set 1: Code-Review-1
Patch Set 1: Code-Review-1
I just nuked these defines because of the inconsistency: https://review.coreboot.org/c/coreboot/+/44029
And the indirection doesn't buy us anything.
I agree, this doesn't make things clearer...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83c8b3a4c5d70ffbf9f2f19975cbf3a021db4ec9
Gerrit-Change-Number: 44064
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Jul 2020 17:20:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment