[coreboot-gerrit] Change in coreboot[master]: lib: ramdetect: Register exception handlers for ARMv8

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34774 )

Change subject: lib: ramdetect: Register exception handlers for ARMv8
......................................................................

Patch Set 8: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/34774/5/src/lib/ramdetect.c 
File src/lib/ramdetect.c:

https://review.coreboot.org/c/coreboot/+/34774/5/src/lib/ramdetect.c@60 
PS5, Line 60: 		exception_handler_unregister(EXC_VID_CUR_SP_EL0_SYNC, &sync_el0);
> Sorry, do you mean that unregistering a handler might affect other parts?

No, I mean the implementation of exception_handler_unregister() has a bug. If you look at it, it walks a list but never updates the 'prev' pointer, so when it unlinks a handler it will unintentionally unlink every handler before that as well.

I doubt that anyone ever tested that function with more than one handler registered...