Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72690 )
Change subject: soc/amd/cezanne/reset: deduplicate code ......................................................................
soc/amd/cezanne/reset: deduplicate code
do_warm_reset does the same as do_cold_reset, since warm resets aren't supported on this platform. Instead of open coding the same cold reset functionality again, call do_cold_reset from do_warm_reset. This also brings do_warm_reset in line with do_board_reset.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460 --- M src/soc/amd/cezanne/reset.c 1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/72690/1
diff --git a/src/soc/amd/cezanne/reset.c b/src/soc/amd/cezanne/reset.c index 1360bd5..ac0c981 100644 --- a/src/soc/amd/cezanne/reset.c +++ b/src/soc/amd/cezanne/reset.c @@ -18,9 +18,7 @@ void do_warm_reset(void) { /* Warm resets are not supported and must be executed as cold */ - pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) | - TOGGLE_ALL_PWR_GOOD); - outb(RST_CPU | SYS_RST, RST_CNT); + do_cold_reset(); }
void do_board_reset(void)