Maccraft123 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: mb/lenovo: DELETEME: Add ThinkPad R60 iGPU support (don't merge working on making it variant board)
......................................................................
Patch Set 50:
(2 comments)
Patch Set 49:
Should be abandoned in favor of Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Well it now _is_ abandoned
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG@15
PS36, Line 15: -Sometimes it takes 20s to boot to payload.
take a look at timestamps with cbmem -t
Will test when i'm back home.
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s...
File src/mainboard/lenovo/r60/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s...
PS20, Line 43: printk(BIOS_DEBUG,
fix code style
I don't really know what to do
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14ea3b91b5108652ce3f951bacea1c1f022da2b1
Gerrit-Change-Number: 35293
Gerrit-PatchSet: 50
Gerrit-Owner: Name of user not set #1002571
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002571
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Oct 2019 14:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment