Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )
Change subject: console/vtxprintf.c: Use same indents for switch/case
......................................................................
Patch Set 2:
(1 comment)
File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/49204/comment/f0ab8371_95b05d80
PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;
TBH, in such cases where the terminating statement (break/continue/goto/
return) is on the same line, I prefer to indent the case line. I would be
very angry if somebody "fixes" my code like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728
Gerrit-Change-Number: 49204
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Thu, 07 Jan 2021 20:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment